feat: expose BaseOverlayImage for external implementation
#1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `_render` to `layout` (added protected metadata) Removed non-virtual metadata from `build` Replaced `Image.color` & `.colorBlendMode` for `opacity` support with normal `.opacity` field using `AlwaysStoppedAnimation` Removed ambient `MapCamera` from `layout` arguments
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
josxha
mootw
approved these changes
Nov 24, 2024
josxha
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstractinstead ofsealed_rendertolayout(added protected metadata)buildImage.color&.colorBlendModeforopacitysupport with normal.opacityfield usingAlwaysStoppedAnimationMapCamerafromlayoutargumentsI feel like we're overcomplicating things, and maybe doing too much for the user? It's much more flexible if we allow the user to pass their own
Image, and not much more difficult if we allow them to do so. I'm not sure if it would work, but then wouldn't any widget work (like https://github.com/TimBaumgart/flutter_map_polywidget), not just images?