Skip to content

Commit

Permalink
PR review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-avinash committed Jul 17, 2024
1 parent f9fb585 commit 5fb0918
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 6 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@
[PR #53](https://github.com/fivetran/dbt_quickbooks_source/pull/53) introduces the following updates:

## 🎉 Feature Update 🎉
- Added the `home_total_amount` field into the `stg_quickbooks__deposit` model to support the new multicurrency feature in the [v0.14.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.14.0).
- Added the following fields to support the new multicurrency feature in the [v0.14.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.14.0):
- `home_total_amount`, into `stg_quickbooks__deposit`.
- `exchange_rate`, into `stg_quickbooks__estimate`.

## 🚘 Under the Hood 🚘
- Included auto-releaser GitHub Actions workflow to automate future releases.
- Updated the maintainer PR template to resemble the most up to date format.
- Removed the check docs GitHub Action as it is no longer necessary.

## Documentation Update
- Added `exchange_rate` and `home_total_amount` fields and descriptions into the relevant yml documents.

# dbt_quickbooks_source v0.10.0

## 🚨 Breaking Change 🚨 :
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,4 @@ We highly encourage and welcome contributions to this package. Check out [this d

# 🏪 Are there any resources available?
- If you have questions or want to reach out for help, please refer to the [GitHub Issue](https://github.com/fivetran/dbt_quickbooks_source/issues/new/choose) section to find the right avenue of support for you.
- If you would like to provide feedback to the dbt package team at Fivetran or would like to request a new dbt package, fill out our [Feedback Form](https://www.surveymonkey.com/r/DQ7K7WW).
- Have questions or want to be part of the community discourse? Create a post in the [Fivetran community](https://community.fivetran.com/t5/user-group-for-dbt/gh-p/dbt-user-group) and our team along with the community can join in on the discussion!
- If you would like to provide feedback to the dbt package team at Fivetran or would like to request a new dbt package, fill out our [Feedback Form](https://www.surveymonkey.com/r/DQ7K7WW).
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions models/src_quickbooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,8 @@ sources:
description: Date of the day which the deposit transaction occurred.
- name: transaction_status
description: Status of the deposit transaction.
- name: home_total_amount
description: Indicates the total amount of the transaction in the home currency. This includes the total of all the charges, allowances, and taxes.
- name: _fivetran_deleted
description: "{{ doc('_fivetran_deleted') }}"

Expand Down Expand Up @@ -407,6 +409,8 @@ sources:
description: Date of the day which the estimate occurred.
- name: transaction_status
description: Current status of the estimate.
- name: exchange_rate
description: The number of home currency units it takes to equal one unit of currency specified by currency_id.
- name: _fivetran_deleted
description: "{{ doc('_fivetran_deleted') }}"

Expand Down
4 changes: 4 additions & 0 deletions models/stg_quickbooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,8 @@ models:
description: Reference to the currency in which all amounts on the associated transaction are expressed.
- name: total_amount
description: Indicates the total amount of the transaction. This includes the total of all the charges, allowances, and taxes.
- name: home_total_amount
description: Indicates the total amount of the transaction in the home currency. This includes the total of all the charges, allowances, and taxes.
- name: transaction_date
description: Date which the deposit transaction occurred.
- name: transaction_status
Expand Down Expand Up @@ -518,6 +520,8 @@ models:
description: Date which the estimate occurred.
- name: transaction_status
description: Current status of the estimate.
- name: exchange_rate
description: The number of home currency units it takes to equal one unit of currency specified by currency_id.
- name: _fivetran_deleted
description: Boolean created by Fivetran to indicate whether the record has been deleted.

Expand Down

0 comments on commit 5fb0918

Please sign in to comment.