Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of tcx2gpx on "0.1.4" due to PEP 604 incompatibility. #165

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

KukovecRok
Copy link
Contributor

Regarding #164 , updated workflow to include req.txt, pyproject.toml, poetry.lock, requirements.txt

This happens only on windows github runner, locally it is fine.

It seems that due to PEP 604 there are errors in tests, when calling library tcx2gpx. It is using ruff for linting, therefore it is using the latest Python Enhancement Proposals. It is unknown if this works with version of python <3.11.

I've fixed the version of tcx2gpx to 0.1.4 for now, since the only main difference in newer version is using ISO timestamps. Also tried with "from future import annotations", but this should be in the original library to prevent version mishaps. Maybe check where iPython version points to? Python is 3.10 or 3.11.

Added tests that uses pip install from requirements.txt instead of poetry for windows.

…ate workflow to include req.txt, pyproject.toml, poetry.lock, requirements.txt
Copy link
Owner

@firefly-cpp firefly-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@firefly-cpp firefly-cpp merged commit 631d764 into firefly-cpp:main Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants