Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dump_cache() to write out intermediate blocks to a blockstore #2101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 11, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (7f8986c) to head (b18a544).

Files with missing lines Patch % Lines
fvm/src/blockstore/buffered.rs 0.00% 6 Missing ⚠️
fvm/src/executor/default.rs 0.00% 4 Missing ⚠️
fvm/src/executor/threaded.rs 0.00% 3 Missing ⚠️
fvm/src/machine/boxed.rs 0.00% 3 Missing ⚠️
fvm/src/machine/default.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   75.96%   74.50%   -1.46%     
==========================================
  Files         154      153       -1     
  Lines       15771    15170     -601     
==========================================
- Hits        11980    11302     -678     
- Misses       3791     3868      +77     
Files with missing lines Coverage Δ
fvm/src/executor/mod.rs 21.21% <ø> (ø)
fvm/src/kernel/default.rs 82.26% <100.00%> (+0.06%) ⬆️
fvm/src/machine/mod.rs 71.21% <ø> (ø)
fvm/src/executor/threaded.rs 71.42% <0.00%> (-11.91%) ⬇️
fvm/src/machine/boxed.rs 0.00% <0.00%> (ø)
fvm/src/machine/default.rs 68.42% <0.00%> (-3.46%) ⬇️
fvm/src/executor/default.rs 76.92% <0.00%> (-0.80%) ⬇️
fvm/src/blockstore/buffered.rs 14.07% <0.00%> (-68.46%) ⬇️

... and 17 files with indirect coverage changes

rvagg added a commit to filecoin-project/lotus that referenced this pull request Jan 11, 2025
* Plumb through dump_cache from fvm4 to access intermediate blocks:
  - filecoin-project/filecoin-ffi#512
  - filecoin-project/ref-fvm#2101
* Enable cache dumping in StateReplay with LOTUS_REPLAY_DUMP_CACHED_BLOCKS
* Add optional "Blocks" field InvocResult
* Handle ExecutionEvent::Log's and add "Logs" field to ExecutionTrace
* Dump intermediate cache blocks to CAR in /tmp when they appear while using
  `lotus-shed msg --exec-trace`.
@rvagg
Copy link
Member Author

rvagg commented Jan 13, 2025

#1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants