Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out claim check to to avoid double claim load in Lotus #333

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Dec 10, 2024

Currently, F3 would iterate over claims AMT, then call the MinerNominalPowerMeetsConsensusMinimum, which would load the same AMT again.

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (65763fd) to head (27c2d58).

Files with missing lines Patch % Lines
builtin/v10/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v11/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v12/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v13/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v14/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v15/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v16/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v8/power/power_state.go 0.00% 14 Missing ⚠️
builtin/v9/power/power_state.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage    3.39%    3.39%   -0.01%     
==========================================
  Files         662      662              
  Lines      177816   177834      +18     
==========================================
  Hits         6041     6041              
- Misses     169926   169944      +18     
  Partials     1849     1849              
Files with missing lines Coverage Δ
builtin/v10/power/power_state.go 0.00% <0.00%> (ø)
builtin/v11/power/power_state.go 0.00% <0.00%> (ø)
builtin/v12/power/power_state.go 0.00% <0.00%> (ø)
builtin/v13/power/power_state.go 0.00% <0.00%> (ø)
builtin/v14/power/power_state.go 0.00% <0.00%> (ø)
builtin/v15/power/power_state.go 0.00% <0.00%> (ø)
builtin/v16/power/power_state.go 0.00% <0.00%> (ø)
builtin/v8/power/power_state.go 28.35% <0.00%> (-0.88%) ⬇️
builtin/v9/power/power_state.go 0.00% <0.00%> (ø)

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, you probably could have just done this for v15 and v16 though

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Dec 11, 2024

cool, you probably could have just done this for v15 and v16 though

I did it only for v16, aider did it for the others.

@rvagg
Copy link
Member

rvagg commented Dec 11, 2024

ok, that's pretty cool

@rvagg rvagg merged commit 0573764 into master Dec 11, 2024
8 checks passed
@rvagg rvagg deleted the feat/claim-optim branch December 11, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants