Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0076 Add Market::GetDealSector method #852

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

anorth
Copy link
Member

@anorth anorth commented Oct 18, 2023

FIPS/fip-0076.md Outdated Show resolved Hide resolved
@jennijuju
Copy link
Member

jennijuju commented Oct 31, 2023

Peer q: How useful is this api without a GetSectorInfo like api? One use case I can think of is using this to figure out when the data will actually mo longer be stored in a sector and trigger a renew deal when it’s close to that time, after finding out the sector i will need to further getting the sector start epoch & duration to get the expiration of the sector.

(would it be useful to add getsectorinfo api as well?

FIPS/fip-0076.md Outdated Show resolved Hide resolved
FIPS/fip-0076.md Outdated Show resolved Hide resolved
FIPS/fip-0076.md Outdated Show resolved Hide resolved
@anorth
Copy link
Member Author

anorth commented Oct 31, 2023

How useful is this api without a GetSectorInfo like api? One use case I can think of is using this to figure out when the data will actually mo longer be stored in a sector and trigger a renew deal when it’s close to that time

The only thing a client should rely on to understand when data will no longer be stored is the deal's duration. The fact that today one can, externally, tell how much longer the data is committed is an artefact of our very limited system that prevents replacing stale data.

I don't know exactly how useful this API will be. Most likely, today, it could be useful in concert with direct state inspection from off-chain. This is one step towards reducing the need for direct state inspection. I don't really think this step should be blocked on having not taken all the other ones at the same time, but I'll just as happily retract this change.

@anorth anorth merged commit 6e29c6c into master Nov 8, 2023
1 check passed
@anorth anorth deleted the anorth/76-marketapi branch November 8, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants