Footer component #31 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Global Style css - Link stylesheet in head Link #9
Made general styling and variables in the style.css
Deze commit is erg groot, dit omdat daan en ik een error hadden met de merge, dus heb ik alles handmatig gedaan
I made a button with a dynamic link and label, i also added some cool animations on it!
Footer gemaakt -dit bestaat uit een grid layout -flexbox op de icons en links -images zijn enhanced en hebben een webP en Avif
Ik heb een hover effect aan de knop toegevoegd en een functie waarmee je de svg uit kan zetten op de knop zodat deze te hergebruiken is
-class op enhanced images verplaatst naar list -h4 veranderd naar h3 -.footer__header-footer veranderd naar .footer__h2 om benoeming in lijn te houden
added font files
-fonts has properly been added
Ik heb comments en alle kleuren custom variabelen gegeven
I made a variable that can turn off the transparant background at 600px
Removed javascript click animation for peformance
-cursor pointer voor incons en links -text-size toegevoegd voor copyright - cursor pointer voor links
In this push, is the html setup for the component
Started editing the css, this isnt finsished. but i want to work further from here
Heb de footer aangepast zodat het onderste gedeelte niet buiten de footer komt
Merge Header component #12
comments added to how i made the enhanced images
deleted the space and removed unused js function
- css white spacing
Optimized the svg into a smaller variant for peformance
links zijn tabbaar
Standaard button component maken #16
list change
-Footer update responsiveness -desktop omgezet naar mobile first
- added small comment
Updated the readme
I forgot to commit earlier, this needs to be picked up by me. Now im going to refector this code.
Ik heb mijn html een refactor gegeven, zo is de code korter
Pull Request Mobile nav#42
-font has been changed and is currently working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer