Deterministic D2GO Trainer Params #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63426319 |
Summary: Pull Request resolved: facebookresearch#677 Previously, cfg.SOLVER.DETERMINISTIC was not taken into account for lightning `Trainer` in d2go: - Nested checks `hasattr(cfg, "SOLVER.DETERMINISTIC")` do not work as expected - If SOLVER.DETERMINISTIC exists, we should check that it is set to `True` Reviewed By: ayushidalmia, rbasch Differential Revision: D63426319
|
This pull request was exported from Phabricator. Differential Revision: D63426319 |
vbourgin
force-pushed
the
export-D63426319
branch
from
0ba524c to
354559c
Compare
|
This pull request has been merged in 5b85625. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, cfg.SOLVER.DETERMINISTIC was not taken into account for lightning
Trainerin d2go:hasattr(cfg, "SOLVER.DETERMINISTIC")do not work as expectedTrueReviewed By: ayushidalmia
Differential Revision: D63426319