Add timeout to unit tests to catch flaky test_dense_image_warp #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test test_dense_image_warp hangs sometimes. I ran it locally 1000 times and I wasn't able to reproduce the error.
This PR adds a timeout to the unit tests, so that we get a stack trace the next time it stalls. Also it doesn't waste 6 hours of compute.
The timeout is set to 5 minutes per test by default.
Changes
Testing
Tested locally, I saw a stack trace on a timeout: