[Fiber] Gate Update flag on BeforeMutationMask on flags #31921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: fc8a898...25cfe7c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Defer to @acdlite because I don't know much about the fiber flags.
What is the Update flag intended to represent?
| ? // TODO: The useEffectEvent hook uses the snapshot phase for clean up but it | ||
| // really should use the mutation phase for this or at least schedule an | ||
| // explicit Snapshot phase flag for this. | ||
| Update |
There was a problem hiding this comment.
I can update useEffectEvent, what's the reasoning for using the mutation phase for cleanup?
There was a problem hiding this comment.
I'm not quite sure why this needs an effect in general but ideally this is more like a read only phase and since it's rarely visited (except I will make heavy use of it in my VT PR) we shouldn't unnecessarily traverse for something unrelated like this.
| @@ -77,17 +80,19 @@ export const MountPassiveDev = /* */ 0b1000000000000000000000000000 | |||
| // don't contain effects, by checking subtreeFlags. | |||
|
|
|||
| export const BeforeMutationMask: number = | |||
| // TODO: Remove Update flag from before mutation phase by re-landing Visibility | |||
| // flag logic (see #20043) | |||
There was a problem hiding this comment.
I think so because there's nothing that refer to it.
rickhanlonii
approved these changes
Jan 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
We're currently visiting the snapshot phase for every `Update` flag even though we rarely have to do anything in the Snapshot phase. The only flags that seem to use these wider visits is `enableCreateEventHandleAPI` and `enableUseEffectEventHook` but really neither of those should do that neither. They should schedule explicit Snapshot phases if needed. DiffTrain build for [6ca7fbe](6ca7fbe)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
We're currently visiting the snapshot phase for every `Update` flag even though we rarely have to do anything in the Snapshot phase. The only flags that seem to use these wider visits is `enableCreateEventHandleAPI` and `enableUseEffectEventHook` but really neither of those should do that neither. They should schedule explicit Snapshot phases if needed. DiffTrain build for [6ca7fbe](6ca7fbe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently visiting the snapshot phase for every
Updateflag even though we rarely have to do anything in the Snapshot phase.The only flags that seem to use these wider visits is
enableCreateEventHandleAPIandenableUseEffectEventHookbut really neither of those should do that neither. They should schedule explicit Snapshot phases if needed.