Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi arch and file-based OLM catalog #79

Closed

Conversation

raelga
Copy link

@raelga raelga commented Nov 27, 2024

  • Updates all build targets with support for arm64 and amd64 images. 6b36cf9
  • Adds the catalog-* targets to generate file-based OLM catalogs. 6b36cf9
  • Adds the release-catalog GitHub workflow, to generate and build a catalog for the operator. 6b36cf9
  • Generates the complete catalog with all bundle releases from v0.3.8 to v0.10.7. cf94821
  • Updates the release documentation with the new targets. abbdada
  • Removes the build step in the test workflow a3ac200

Related to:

@raelga raelga force-pushed the feat/multi-arch-and-catalog branch 5 times, most recently from d71af51 to 0106777 Compare November 28, 2024 09:05
@Skarlso
Copy link

Skarlso commented Nov 29, 2024

Hello. :) You have a test failure:

Error: must build at directory: not a valid directory: evalsymlink failure on 'config/testing' : lstat /home/runner/work/external-secrets-helm-operator/external-secrets-helm-operator/config/testing: no such file or directory
error: no objects passed to apply

@raelga raelga force-pushed the feat/multi-arch-and-catalog branch 3 times, most recently from 99f58ad to 0376536 Compare December 4, 2024 11:40
Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
@raelga raelga force-pushed the feat/multi-arch-and-catalog branch from 0376536 to a3ac200 Compare December 4, 2024 11:44
@raelga
Copy link
Author

raelga commented Dec 4, 2024

@Skarlso It should be working now

@gusfcarvalho
Copy link
Member

Hi @raelga . We internally have been discussing the feasibility of maintaining OLM releases within our team for a while now, and it is clear from past releases (external-secrets/external-secrets#4036) we are not par to maintaining and further releasing OLM builds anymore.

On the community meeting today I have proposed external-secrets/external-secrets#4175 and it was approved.

While this does not mean we are not having any support for OLM in the future, it is clear that a helm operator for OLM is not the way we want to go. As such, if we can find people to proper support an OLM operator for external-secrets, we will be more than happy to incorporate it again - as long as this is not a forcing function of the current release process.

As such, I am closing your contribution. Sorry about all of the fuss this might have caused 🙏 🙇

@raelga
Copy link
Author

raelga commented Dec 4, 2024

It's OK @gusfcarvalho, let us know if you need any help with the non-helm based operator. We are more than happy to help.

In the meantime, we are probably going to internally deprecate the usage of OLM operator and deploy directly with Helm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants