Remove bad makefile target gha #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One remark: The test in (4) still failed silently (look into the ci-run after my second commit). The scope of my PR is not to solve this, but I added a comment to this issue #134. |
ErikSchierboom
approved these changes
May 10, 2022
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master, main] |
There was a problem hiding this comment.
If you'd like, you could do a follow-up PR to change this to:
Suggested change
| branches: [master, main] | |
| branches: [main] |
We've moved to using main for all repos.
|
Merged. Thanks a lot! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified the test-setup in the spirit of issue #196. I did the following:
ghaand the related targetdebug.ci.ymlandci-pull-request.ymlinto one file (ci.yml).make testto execute all tests inci.yml../bin/generate --test-only binary) since it was (silently) failing.I did (1) and (3) because, as discussed in the issue, the current setup is already so complicated that tests started to fail silently. Moreover, the
debugtarget did not completely take into account that the default target isn'tmasteranymore. I did (2) to avoid code duplication. That the failing test in (4) wasn't discovered before, shows that (3) is a good move (in my opinion).