Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update due to try changes #169

Merged
merged 1 commit into from
Dec 10, 2024
Merged

update due to try changes #169

merged 1 commit into from
Dec 10, 2024

Conversation

Anton-4
Copy link
Contributor

@Anton-4 Anton-4 commented Dec 10, 2024

I believe this changed because of roc-lang/roc#7313

These changes prevent errors like this:

── TRY OUTSIDE OF FUNCTION in circular-buffer-test.roc ─────────────────────────

This try doesn't belong to a function:

234│>          create { capacity: 3 }
235│>              |> write? 1
236│>              |> write? 2
237│>              |> write? 3

I wouldn't know where to return to if I used it!

These errors happen when using the latest main branch of Roc

I believe this changed because of roc-lang/roc#7313
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Anton-4
Copy link
Contributor Author

Anton-4 commented Dec 10, 2024

Yes, [no important files changed] can be added to the merge commit message, no need to rerun tests that used the old nightly.

@Anton-4 Anton-4 requested a review from isaacvando December 10, 2024 13:38
Copy link
Contributor

@isaacvando isaacvando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Anton-4!

@isaacvando isaacvando merged commit 8599c16 into main Dec 10, 2024
4 checks passed
@isaacvando isaacvando deleted the try-updates branch December 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants