Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meetup exercise #151

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Add meetup exercise #151

merged 2 commits into from
Oct 19, 2024

Conversation

ageron
Copy link
Contributor

@ageron ageron commented Oct 12, 2024

Sadly the roc-isodate package does not provide a way to know a date's weekday, or to figure out how many days a month has. I've submitted a PR and an issue for that. Also, even though the roc-isodate package defines the isLeapYear function, it's not exposed, I've asked for that function to be exposed.

So perhaps we should wait until it's merged and a new version is released and the test runner is updated to use that version before launching this exercise, otherwise a large part of the effort is in implementing these functions, and it looks bad for Roc.
On the other hand I had fun implementing these functions... Wdyt?

@Anton-4
Copy link
Contributor

Anton-4 commented Oct 14, 2024

perhaps we should wait until it's merged and a new version is released and the test runner is updated to use that version before launching this exercise

I would indeed prefer this

@imclerran
Copy link

Saw your PR - I'll work on adding the requested features this week.

@imclerran
Copy link

imclerran commented Oct 16, 2024

Alright, all the requested functions have been added and released in v0.5.1!

@ageron
Copy link
Contributor Author

ageron commented Oct 17, 2024

Cool, thanks @imclerran , I updated this exercise to use isodate version 0.5.1, the solution is much shorter now that I can just import weekday and dayOfMonth. 👍
Note: before we merge this PR, we must wait until the roc-test-runner is upgraded to support isodate 0.5.1 (see exercism/roc-test-runner#16)

Copy link
Contributor

@isaacvando isaacvando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ageron ageron merged commit c4256ae into exercism:main Oct 19, 2024
2 checks passed
@ageron ageron deleted the add-meetup branch October 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants