Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly the
roc-isodate
package does not provide a way to know a date's weekday, or to figure out how many days a month has. I've submitted a PR and an issue for that. Also, even though theroc-isodate
package defines theisLeapYear
function, it's not exposed, I've asked for that function to be exposed.So perhaps we should wait until it's merged and a new version is released and the test runner is updated to use that version before launching this exercise, otherwise a large part of the effort is in implementing these functions, and it looks bad for Roc.
On the other hand I had fun implementing these functions... Wdyt?