Add run-length-encoding exercise #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacvando
reviewed
Oct 11, 2024
isaacvando
approved these changes
Oct 11, 2024
Replace `|> \state -> appendCountAndLetter state` with `|> appendCountAndLetter` as suggested by Isaac. Co-authored-by: Isaac Van Doren <69181572+isaacvando@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the instructions specify that the input strings will always be simple ASCII, the
BadUtf8error can never really happen, so the annotation forencodecould just beStr -> Str, but it's simpler for the user if the annotation isStr -> Result Str _, this way they can just callStr.fromUtf8without having to worry about it.Moreover, a very long string of digits could break
decode, so it's also simpler to use annotationStr -> Result Str _.