Skip to content

Commit

Permalink
Upgrade electron 33.0.2 -> 33.1.0, code quality fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
everoddandeven committed Nov 7, 2024
1 parent 920a9cf commit aa0c75e
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@typescript-eslint/eslint-plugin": "7.7.1",
"@typescript-eslint/parser": "7.7.1",
"conventional-changelog-cli": "5.0.0",
"electron": "33.0.2",
"electron": "33.1.0",
"electron-builder": "25.1.8",
"electron-debug": "4.1.0",
"electron-installer-dmg": "5.0.1",
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/detail/detail.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export class DetailComponent extends BasePageComponent implements AfterViewInit
});
});

const daemonStatusSub = this.daemonService.onDaemonStatusChanged.subscribe((running: boolean) => {
const daemonStatusSub: Subscription = this.daemonService.onDaemonStatusChanged.subscribe((running: boolean) => {
if (!running) {
this.destroyTables();
}
Expand Down
4 changes: 2 additions & 2 deletions src/app/pages/mining/mining.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
user-select: none;
}

@media (min-width: 768px) {
@media (width >= 768px) and (min-width: 768px) {
.bd-placeholder-img-lg {
font-size: 3.5rem;
}
Expand All @@ -27,7 +27,7 @@

.bi {
vertical-align: -.125em;
fill: currentColor;
fill: currentcolor;
}

.nav-scroller {
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/components/navbar/navbar.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class NavbarComponent implements AfterViewInit, OnDestroy {

queryResult.forEach((el) => tooltipTriggerList.push(el));

const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl, {
const tooltipList: bootstrap.Tooltip[] = tooltipTriggerList.map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl, {
placement: 'bottom'
}));

Expand Down
3 changes: 1 addition & 2 deletions src/app/shared/components/sidebar/sidebar.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ main {
height: 100vh;
height: -webkit-fill-available;
max-height: 100vh;
overflow-x: auto;
overflow-y: hidden;
overflow: auto scroll;
}

.dropdown-toggle { outline: 0; }
Expand Down
3 changes: 2 additions & 1 deletion src/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ $primary: #ff5733;
}


@media (min-width: 768px) {
@media (width >= 768px) and (min-width: 768px) {
.sidebar {
position: fixed !important;
}

.sidebar .offcanvas-lg {
position: sticky;
top: 48px;
Expand Down

0 comments on commit aa0c75e

Please sign in to comment.