Merge branch 'modularize_refactor' into 'master'

Add linting of the new devlab_bench package/module

See merge request te/devlab!15

.gitlab-ci.yml

@@ -18,6 +18,7 @@ syntax:
     - python -m py_compile devlab
     - python -m py_compile installer.py
     - pylint devlab
+    - pylint -E devlab_bench
     - pylint installer.py
 
 make_pkg:

devlab_bench/actions/down.py

@@ -52,7 +52,7 @@ def action(components='*', rm=False, **kwargs):
         components_to_stop = get_ordinal_sorting(components_to_stop, config['components'])
     components_to_stop.reverse()
     for comp in components_to_stop:
-        comp_cont_name = '{}-devlab'.format(comp)
+        comp_cont_name = '{}-devlab'.format(comp) #pylint: disable=duplicate-code
         if comp == foreground_comp_name:
             comp_type = config['foreground_component'].get('type', 'container')
         else:

devlab_bench/helpers/__init__.py

@@ -4,6 +4,4 @@
 import os
 import sys
 
-import devlab_bench.helpers.command
-import devlab_bench.helpers.docker
-from devlab_bench.helpers.common import * #pylint: disable=wildcard-import
+from devlab_bench.helpers.common import * #pylint: disable=wildcard-import,cyclic-import

devlab_bench/helpers/command.py

@@ -31,7 +31,7 @@ class Command(object):
         log_output: bool, whether to send the output of the command to the logger
         logger: Logger object to use for messages
     """
-    def __init__(self, path, args=None, env=None, ignore_nonzero_rc=False, interactive=False, split=True, suppress_error_out=False, stdin=None, timeout=0, use_shell=False, log_output=False, logger=None, **kwargs):
+    def __init__(self, path, args=None, env=None, ignore_nonzero_rc=False, interactive=False, split=True, suppress_error_out=False, stdin=None, timeout=0, use_shell=False, log_output=False, logger=None, **kwargs): #pylint: disable=too-many-arguments
         """
         Initialize the command object
         """

devlab_bench/helpers/common.py

@@ -13,7 +13,7 @@
 import sys
 from copy import deepcopy
 
-import devlab_bench
+import devlab_bench #pylint: disable=cyclic-import
 from devlab_bench.exceptions import DevlabComponentError
 
 #Python2/3 compatibility