Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/PRO-2467/update-modular-modules-func #157

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat/PRO-2467/update-modular-modules-func #157

merged 2 commits into from
Jul 11, 2024

Conversation

RanaBug
Copy link
Contributor

@RanaBug RanaBug commented Jul 10, 2024 •
edited
Loading

Description

  • New modular functions have been added: isModuleInstalled, generateModuleDeInitData and getAllModules
  • generateModuleDeInitData is within the uninstallModule function as this deInitData needs to be generated when we want to uninstall a module
  • Updated getAssets function which now accepts any chainId and name as optional props

How Has This Been Tested?

  • Unit test for new modular functions

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 10, 2024 17:13
@RanaBug RanaBug self-assigned this Jul 10, 2024
@linear Linear
Copy link

linear bot commented Jul 10, 2024

PRO-2467 Update Px with latest TxKit

IAmKio
IAmKio requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions and questions, other than that it looks good!

src/hooks/useEtherspotAssets.ts Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Show resolved Hide resolved
src/hooks/useEtherspotModules.ts Show resolved Hide resolved
IAmKio
IAmKio approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RanaBug RanaBug merged commit 355ade3 into master Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

Assignees

@RanaBug RanaBug

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RanaBug @IAmKio