Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-2136 - Bundler Api Key #99

Merged
merged 8 commits into from
Feb 12, 2024
Merged

PRO-2136 - Bundler Api Key #99

merged 8 commits into from
Feb 12, 2024

Conversation

vignesha22
Copy link
Contributor

@vignesha22 vignesha22 commented Jan 30, 2024

Description

  • Added GenericBundler and EtherspotBundler as bundlerProviders and removed bundlerUrl params from SdkOptions

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link

linear bot commented Jan 30, 2024

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etherspot etherspot deleted a comment from gitguardian bot Feb 12, 2024
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add in readme that this is public API key with rate limits, to get higher limits register to https://portal.etherspot.io

@vignesha22 vignesha22 requested a review from arddluma February 12, 2024 18:44
@etherspot etherspot deleted a comment from gitguardian bot Feb 12, 2024
@vignesha22 vignesha22 merged commit 514bc23 into master Feb 12, 2024
4 of 6 checks passed
@vignesha22 vignesha22 deleted the PRO-2136-Bundler_ApiKey branch February 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants