-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: concurrent userops & example #97
Conversation
Yooo! You forgot to bump the version in package.json! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change on versioning
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@etherspot/prime-sdk", | |||
"version": "1.4.2", | |||
"version": "1.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to 1.5.0 please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove yarn.lock as NPM is used currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
key
param insdk.estimate
function to make use all values of semi-abstraced nonce that allows to send many userops from one wallet at once (https://eips.ethereum.org/EIPS/eip-4337#semi-abstracted-nonce-support)Types of changes
What types of changes does your code introduce?
Further comments (optional)