Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-1861 - Error handling and apollo/client package fixes #63

Merged
merged 7 commits into from
Oct 31, 2023
Merged

PRO-1861 - Error handling and apollo/client package fixes #63

merged 7 commits into from
Oct 31, 2023

Conversation

vignesha22
Copy link
Contributor

Description

  • Added possibleSolution parameter for the errors that are commonly returned from the bundler which are taken from the eip4337 error codes
  • Updated package dependencies for the apollo/client
  • Updated config.yml to point to this branch for running e2e tests temporarily.

How Has This Been Tested?

  • Tested Locally and build also was successful

Screenshots (if appropriate):

Screenshot 2023-10-31 at 5 45 37 AM Screenshot 2023-10-31 at 5 42 41 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@linear
Copy link

linear bot commented Oct 31, 2023

PRO-1861 Etherspot Prime SDK: Error Handling

Description:

Currently, nearly all errors being returned from the backend via the SDK return an unhelpful message saying "transaction reverted".

This needs to become more accurate into what exactly went wrong, instead of a catch-all message.

Pre-requisites:

  • N/A

Requirements:

  • Alter the SDK to return more relevent, helpful responses when an error occurs
    • The error message should contain an accurate error message
    • The error message should attempt to offer a remedy to fix the solution

Resources:

  • N/A

User stories:

  • Success stories
    • As an SDK user, when an error occurs, the SDK should throw an error with an accurate error message into what has gone wrong, and what can be done to fix the error.

Specific Acceptance Criteria:

  • As per the user stories above.

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

@ch4r10t33r
Copy link
Member

@vignesha22 pls can you address the issue related to failing e2e tests?

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

ch4r10t33r
ch4r10t33r approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

@vignesha22
Copy link
Contributor Author

Please ignore the package version update as 1.3.9 is not yet published as that merge with master failed to build because of dependencies outdated @0xSulpiride @lbw33 @kaushalrajbacancy

@github-actions
Copy link

Yooo! You forgot to bump the version in package.json!

This was linked to issues Oct 31, 2023
SDK fails to build #57
Closed
Replace Apollo Client and @nerdwallet/apollo-cache-policies #58
Closed
@arddluma arddluma merged commit a01b6b4 into master Oct 31, 2023
1 of 2 checks passed
@arddluma arddluma deleted the PRO-1861-Error_handling branch October 31, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kaushalrajbacancy kaushalrajbacancy kaushalrajbacancy approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Apollo Client and @nerdwallet/apollo-cache-policies SDK fails to build
5 participants
@vignesha22 @ch4r10t33r @cryptonoyaiba @kaushalrajbacancy @arddluma