Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apollo #55

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Fix apollo #55

merged 6 commits into from
Oct 28, 2023

Conversation

ch4r10t33r
Copy link
Member

Upgraded Apollo packages

Description

Several developers were facing issues and warnings because of a very old version of the Apollo package being used as a dependency.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ch4r10t33r ch4r10t33r requested review from IAmKio and arddluma October 28, 2023 16:23
@ch4r10t33r ch4r10t33r requested a review from vignesha22 October 28, 2023 16:31
package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update in package-lock.json too

@ch4r10t33r
Copy link
Member Author

ch4r10t33r commented Oct 28, 2023

Please update in package-lock.json too

Shouldn't that get auto-generated?

@IAmKio
Copy link

IAmKio commented Oct 28, 2023

@ch4r10t33r can i just check that we were able to install and run the examples? I can't see any automated tests in the build pipeline...

@ch4r10t33r ch4r10t33r requested a review from arddluma October 28, 2023 16:43
.gitignore Outdated Show resolved Hide resolved
@ch4r10t33r
Copy link
Member Author

Please update in package-lock.json too

Shouldn't that get auto-generated?

This is done.,

@ch4r10t33r ch4r10t33r merged commit e0b5d95 into master Oct 28, 2023
2 checks passed
@arddluma arddluma deleted the fix_apollo branch November 1, 2023 14:30
@arddluma arddluma restored the fix_apollo branch November 1, 2023 14:30
@arddluma arddluma deleted the fix_apollo branch May 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants