core/types: change SetCodeTx.ChainID to uint256 #30982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested review from
lightclient
and removed request for
holiman and
rjl493456442
s1na
reviewed
Jan 3, 2025
Co-authored-by: Sina M <1591639+s1na@users.noreply.github.com>
|
Hmm. So now it's a bit inconsistent with |
These objects are not used with JSON directly, so it's confusing to have the comments.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to decide how to handle non-specfic
chainIdin the JSON encoding of authorizations. WithchainIdbeing a uint64, the previous implementation just used value zero. However, it might actually be more correct to use the valuenullfor this case.