Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit correct block hash in random Electra tests #4072

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

etan-status
Copy link
Contributor

New tests were added in #4032 with incorrect EL block hash, fix these.

New tests were added in ethereum#4032 with incorrect EL block hash, fix these.
@etan-status
Copy link
Contributor Author

✅ Validated against nimbus that alpha.10 + this PR have no invalid block hashes once again. Last time new tests got added after validating against nimbus, so this one was not caught until later.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we always have issues with this. Thank you for fixing this again.

@jtraglia jtraglia merged commit 0c4c9e4 into ethereum:dev Jan 6, 2025
12 checks passed
@etan-status etan-status deleted the ef-reqhash branch January 6, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants