-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix findings from Dmitry's review #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Highlighting some things that can be improved IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jtraglia and also @khovratovich !
I left some comments, but most of it looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
Co-authored-by: Benedikt Wagner <113296072+b-wagn@users.noreply.github.com>
Co-authored-by: Benedikt Wagner <113296072+b-wagn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot everyone here!
This PR is a work in progress. It does the following things:
com.diffplug.spotless
to work with Java 22.compute_fk20_proofs
tocompute_fk20_cell_proofs
.compute_fk20_cell_proofs
to acceptFIELD_ELEMENTS_PER_BLOB
length poly.build
in Python bindings.fr_is_null
edge case in recovery.coset_factor_pow
.Big thanks to @khovratovich 🙏
If we choose to, we can do larger renaming fixes in a separate PR.