fix: replace OpenSensus with OpenTelemetry and fix exception handling #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinlokken
force-pushed
the
fix/replace-open-census
branch
from
2ea9b99 to
5485cab
Compare
collinlokken
force-pushed
the
fix/replace-open-census
branch
from
e81133c to
2dc5881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
OpenSensus is deprecated and should be migrated to OpenTelemetry
To support correct tracing, exceptions in the api routers should be handled differently
What does this pull request change?
ExceptionHandlingRoutethat wraps requests in try/except to capture and handle excpetions on our owncryptographyas a separate dependency as it was included with OpenSensusIssues related to this change:
Closes #251