Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support appending to data lists #788

Closed

Conversation

simonbaird
Copy link
Member

The goal is to allow users to append to rule data without overwriting the original rule data. This can be used to add a custom task to data.task-bundles for example.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #788 (7810fb7) into main (0ed9fe3) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           86        86           
  Lines         3342      3363   +21     
=========================================
+ Hits          3342      3363   +21     
Files Coverage Δ
policy/lib/rule_data.rego 100.00% <100.00%> (ø)
policy/lib/rule_data_test.rego 100.00% <100.00%> (ø)

The goal is to allow users to append to rule data without
overwriting the original rule data. This can be used to add a custom
task to data.task-bundles for example.
@simonbaird
Copy link
Member Author

Move this to draft since the task-bundles is actually a map not an array, which I had forgotten about.

@simonbaird simonbaird marked this pull request as draft October 31, 2023 14:55
@simonbaird simonbaird closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants