Use .statement.predicate everywhere instead of just .predicate #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbestavros
force-pushed
the
gh-756
branch
2 times, most recently
from
d6f3546 to
c1e3c8d
Compare
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 84 -2
Lines 3342 3318 -24
=========================================
- Hits 3342 3318 -24
|
zregvart
approved these changes
Oct 18, 2023
|
More work needs to be done. See |
mbestavros
force-pushed
the
gh-756
branch
3 times, most recently
from
f77dd06 to
3daa0ba
Compare
simonbaird
previously requested changes
Oct 19, 2023
simonbaird
reviewed
Oct 20, 2023
mbestavros
force-pushed
the
gh-756
branch
7 times, most recently
from
46d6e5e to
404dd61
Compare
|
The test that is failing appears to be a bad test which has been exposed! This makes it pass: diff --git a/policy/release/step_image_registries_test.rego b/policy/release/step_image_registries_test.rego
index 73b88a0..627ff6f 100644
--- a/policy/release/step_image_registries_test.rego
+++ b/policy/release/step_image_registries_test.rego
@@ -66,7 +66,7 @@ test_unexpected_image_ref if {
lib.assert_equal_results(step_image_registries.deny, {{
"code": "step_image_registries.task_step_images_permitted",
"msg": sprintf("Step 0 in task 'mytask' has disallowed image ref '%s'", [unexpected_image]),
- }}) with input.attestations as mock_data(unexpected_image)
+ }}) with input.attestations as [mock_data(unexpected_image)]
}
test_step_image_registry_prefix_list_found if { |
mbestavros
force-pushed
the
gh-756
branch
4 times, most recently
from
bbcfb7b to
6428ba3
Compare
|
@lcarva I thought that might have been it! I tried that fix in the library function, but that still broke things. Didn't think to do it in the test itself. Thanks! Tests do indeed pass now! 🎉 |
lcarva
reviewed
Nov 1, 2023
mbestavros
force-pushed
the
gh-756
branch
2 times, most recently
from
019bc08 to
dae3b97
Compare
Signed-off-by: Mark Bestavros <mbestavr@redhat.com>
simonbaird
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #756.