Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit term for base_image_permitted #1230

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Emit term for base_image_permitted #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions antora/docs/modules/ROOT/pages/release_policy.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ Confirm the `allowed_registry_prefixes` rule data was provided, since it's requi
* Rule type: [rule-type-indicator failure]#FAILURE#
* FAILURE message: `%s`
* Code: `base_image_registries.allowed_registries_provided`
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/release/base_image_registries/base_image_registries.rego#L77[Source, window="_blank"]
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/release/base_image_registries/base_image_registries.rego#L78[Source, window="_blank"]

[#base_image_registries__base_image_permitted]
=== link:#base_image_registries__base_image_permitted[Base image comes from permitted registry]
Expand All @@ -335,7 +335,7 @@ Verify the expected information was provided about which base images were used d
* Rule type: [rule-type-indicator failure]#FAILURE#
* FAILURE message: `Base images information is missing`
* Code: `base_image_registries.base_image_info_found`
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/release/base_image_registries/base_image_registries.rego#L47[Source, window="_blank"]
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/release/base_image_registries/base_image_registries.rego#L48[Source, window="_blank"]

[#buildah_build_task_package]
== link:#buildah_build_task_package[Buildah build task]
Expand Down
3 changes: 2 additions & 1 deletion policy/release/base_image_registries/base_image_registries.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ import data.lib.sbom
deny contains result if {
some image_ref in _base_images
not _image_ref_permitted(image_ref)
result := lib.result_helper(rego.metadata.chain(), [image_ref])
repo := image.parse(image_ref).repo
result := lib.result_helper_with_term(rego.metadata.chain(), [image_ref], repo)
}

# METADATA
Expand Down
5 changes: 5 additions & 0 deletions policy/release/base_image_registries/base_image_registries_test.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,17 @@ test_disallowed_base_images if {
{
"code": "base_image_registries.base_image_permitted",
"msg": "Base image \"registry.redhat.yo/ubi7/3\" is from a disallowed registry",
"term": "registry.redhat.yo/ubi7/3",
},
{
"code": "base_image_registries.base_image_permitted",
"msg": "Base image \"registry.redhat.ioo/spam/3\" is from a disallowed registry",
"term": "registry.redhat.ioo/spam/3",
},
{
"code": "base_image_registries.base_image_permitted",
"msg": "Base image \"dockery.io/busybox/3\" is from a disallowed registry",
"term": "dockery.io/busybox/3",
},
}
lib.assert_equal_results(base_image_registries.deny, expected) with lib.sbom.cyclonedx_sboms as sboms
Expand Down Expand Up @@ -136,10 +139,12 @@ test_disallowed_base_images_with_snapshot if {
{
"code": "base_image_registries.base_image_permitted",
"msg": "Base image \"docker.io/library/registry:latest@sha256:bcd\" is from a disallowed registry",
"term": "docker.io/library/registry",
},
{
"code": "base_image_registries.base_image_permitted",
"msg": "Base image \"registry.redhat.io/ubi7:latest@sha256:abc\" is from a disallowed registry",
"term": "registry.redhat.io/ubi7",
},
}

Expand Down