Skip to content

Commit

Permalink
Merge pull request #1181 from simonbaird/repo-id-check-enable
Browse files Browse the repository at this point in the history
Enable rpm repo id check in redhat collection effective in 30 days
  • Loading branch information
lcarva authored Oct 10, 2024
2 parents ce24a1d + 9f3eec3 commit cacea1d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion antora/docs/modules/ROOT/pages/release_policy.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ Rules included:
* xref:release_policy.adoc#provenance_materials__git_clone_source_matches_provenance[Provenance Materials: Git clone source matches materials provenance]
* xref:release_policy.adoc#provenance_materials__git_clone_task_found[Provenance Materials: Git clone task found]
* xref:release_policy.adoc#quay_expiration__expires_label[Quay expiration: Expires label]
* xref:release_policy.adoc#rpm_repos__ids_known[RPM Repos: All rpms have known repo ids]
* xref:release_policy.adoc#rpm_repos__rule_data_provided[RPM Repos: Known repo id list provided]
* xref:release_policy.adoc#rpm_signature__allowed[RPM Signature: Allowed RPM signature key]
* xref:release_policy.adoc#rpm_signature__result_format[RPM Signature: Result format]
Expand Down Expand Up @@ -1033,13 +1034,14 @@ This package defines rules to confirm that all RPM packages listed in SBOMs spec
[#rpm_repos__ids_known]
=== link:#rpm_repos__ids_known[All rpms have known repo ids]

Each RPM package listed in an SBOM must specify the repository id that it comes from, and that repository id must be present in the list of known and permitted repository ids.
Each RPM package listed in an SBOM must specify the repository id that it comes from, and that repository id must be present in the list of known and permitted repository ids. Currently this is rule enforced only for SBOM components created by cachi2.

*Solution*: Ensure every rpm comes from a known and permitted repository, and that the data in the SBOM correctly records that.

* Rule type: [rule-type-indicator failure]#FAILURE#
* FAILURE message: `RPM repo id check failed: %s`
* Code: `rpm_repos.ids_known`
* Effective from: `2024-11-10T00:00:00Z`
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/release/rpm_repos.rego#L33[Source, window="_blank"]

[#rpm_repos__rule_data_provided]
Expand Down
8 changes: 4 additions & 4 deletions policy/release/rpm_repos.rego
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,16 @@ deny contains result if {
# description: >-
# Each RPM package listed in an SBOM must specify the repository id that it comes from,
# and that repository id must be present in the list of known and permitted repository ids.
# Currently this is rule enforced only for SBOM components created by cachi2.
# custom:
# short_name: ids_known
# failure_msg: 'RPM repo id check failed: %s'
# solution: >-
# Ensure every rpm comes from a known and permitted repository, and that the data in the
# SBOM correctly records that.
# # Todo: Until the sbom generation is upated this will always fail, so don't include it
# # in the redhat collection yet. See https://issues.redhat.com/browse/STONEBLD-2638
# #collections:
# #- redhat
# collections:
# - redhat
# effective_on: "2024-11-10T00:00:00Z"
#
deny contains result if {
# Don't bother with this unless we have valid rule data
Expand Down

0 comments on commit cacea1d

Please sign in to comment.