Allow unpinned refs in descriptor/image_manifest #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `ec.oci.descriptor` and the `ec.oci.image_manifest` rego functions to allow image refs without a digest to be used. This allows rego policies to be more granular by splitting the "pinned" checks from the "availability" checks. Ref: EC-1038 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
+ Coverage 72.69% 72.74% +0.04%
==========================================
Files 88 88
Lines 7622 7656 +34
==========================================
+ Hits 5541 5569 +28
- Misses 2081 2087 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
simonbaird
approved these changes
Jan 10, 2025
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
ec.oci.descriptorand theec.oci.image_manifestrego functions to allow image refs without a digest to be used.This allows rego policies to be more granular by splitting the "pinned" checks from the "availability" checks.
Ref: EC-1038