Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing OPA evaluator #2252

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

joejstuart
Copy link
Member

This just creates the option to use OPA by setting the EC_USE_OPA env variable.

https://issues.redhat.com/browse/EC-1044

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.72%. Comparing base (9d4f0a8) to head (9eb4a60).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/evaluator/opa_evaluator.go 80.00% 2 Missing ⚠️
cmd/validate/image.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   72.69%   72.72%   +0.02%     
==========================================
  Files          88       89       +1     
  Lines        7622     7640      +18     
==========================================
+ Hits         5541     5556      +15     
- Misses       2081     2084       +3     
Flag Coverage Δ
generative 72.72% <84.21%> (+0.02%) ⬆️
integration 72.72% <84.21%> (+0.02%) ⬆️
unit 72.72% <84.21%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/utils/helpers.go 70.73% <100.00%> (+0.73%) ⬆️
cmd/validate/image.go 90.50% <85.71%> (-0.10%) ⬇️
internal/evaluator/opa_evaluator.go 80.00% <80.00%> (ø)

@joejstuart joejstuart force-pushed the opa-eval branch 3 times, most recently from 25dc234 to 9652e50 Compare January 8, 2025 22:46
cmd/validate/image.go Outdated Show resolved Hide resolved
@joejstuart joejstuart enabled auto-merge January 9, 2025 20:10
@joejstuart joejstuart force-pushed the opa-eval branch 2 times, most recently from 8d658a7 to 8353e69 Compare January 9, 2025 22:33
This just creates the option to use OPA by
setting the EC_USE_OPA env variable. It will
return an emtpy.

https://issues.redhat.com/browse/EC-1044
@joejstuart joejstuart merged commit 7f35564 into enterprise-contract:main Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants