Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML-escaping of description #1151

Merged

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Nov 7, 2023

The description text must not be HTML escaped, otherwise it could break Asciidoc syntax.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1151 (9113230) into main (6b1567c) will decrease coverage by 14.63%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 9113230 differs from pull request most recent head 8482f20. Consider uploading reports for the commit 8482f20 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1151       +/-   ##
===========================================
- Coverage   84.87%   70.25%   -14.63%     
===========================================
  Files          65       62        -3     
  Lines        5124     5069       -55     
===========================================
- Hits         4349     3561      -788     
- Misses        775     1508      +733     
Flag Coverage Δ
acceptance 70.25% <ø> (ø)
generative ?
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

@zregvart zregvart force-pushed the pr/dont-html-escape-description branch from 5f8cf5d to 9113230 Compare November 8, 2023 09:58
The description text must not be HTML escaped, otherwise it could break
Asciidoc syntax.
@zregvart zregvart force-pushed the pr/dont-html-escape-description branch from 9113230 to 8482f20 Compare November 8, 2023 10:39
@zregvart zregvart merged commit 1d135d6 into enterprise-contract:main Nov 8, 2023
7 checks passed
@zregvart zregvart deleted the pr/dont-html-escape-description branch November 8, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant