-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ec.fetch_oci_blob rego function #1107
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
+ Coverage 84.16% 84.24% +0.08%
==========================================
Files 63 64 +1
Lines 4988 5071 +83
==========================================
+ Hits 4198 4272 +74
- Misses 790 799 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1bbb320
to
b54edef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about the naming, and if ec.oci.blob
could be a better name, or even if we want to push this upstream to OPA and have it opa.blob
?
Some nitpicks inside, other than that 👍
Updated to go with I think you probably meant |
Caching is not working. I need to rethink the approach. Put it in draft for now. |
I'm gonna hold off on the cache approach for this PR due to google/go-containerregistry#1821. |
FYI, code coverage is failing to be uploaded. It is a known issue and it happens from time to time... |
Resolves enterprise-contract#1070 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
It implements #1070, but it doesn't resolve it just yet. As a followup PR, I'll add acceptance tests to complete this functionality.UPDATE: Acceptance tests are now included.