Merge pull request #277 from ensdomains/fix-invalid-warning

Fix problem not showing warning on invalid address/content
ensdomains · May 8, 2019 · 0c72e90 · 0c72e90
2 parents 7f24f2e + f493a86
commit 0c72e90
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/components/SingleName/AddRecord.js b/src/components/SingleName/AddRecord.js
@@ -97,6 +97,7 @@ function Editable({ domain, emptyRecords, refetch }) {
     value: newValue,
     contentType: domain.contentType
   })
+  const isInvalid = newValue !== "" && !isValid
   return (
     <>
       <RecordsTitle>
@@ -133,8 +134,8 @@ function Editable({ domain, emptyRecords, refetch }) {
               dataType={selectedRecord ? selectedRecord.value : null}
               contentType={domain.contentType}
               updateValue={updateValue}
-              valid={isValid}
-              invalid={!isValid}
+              isValid={isValid}
+              isInvalid={isInvalid}
             />
           </Row>
           {selectedRecord ? (

diff --git a/src/components/SingleName/RecordsItem.js b/src/components/SingleName/RecordsItem.js
@@ -118,8 +118,8 @@ const Editable = ({
     value: newValue,
     contentType: domain.contentType
   })
-  const isInvalid = !isValid && newValue.length > 0 && type === 'address'
 
+  const isInvalid = newValue !== "" && !isValid
   return (
     <>
       <Mutation

diff --git a/src/utils/records.js b/src/utils/records.js
@@ -7,10 +7,10 @@ export function validateRecord(record) {
 
   const { type, value } = record
 
-  if (record.contentType === 'oldcontent') {
+  if (type == 'content' && record.contentType === 'oldcontent') {
     return value.length > 32
   }
-  console.log('validateRecord', { record })
+
   switch (type) {
     case 'address':
       return addressUtils.isAddress(value)