-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the outfitter key assets for endless-sky PR 10743 #186
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected to have a @2x
file in the regular asset repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
xobes, the 2x should probably be in a PR to the high dpi plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the corresponding PR is over there: endless-sky/endless-sky-high-dpi#430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I opened the .xcf file to apply shading, it was already sized for the @2x png, so I saved it off with a more appropriate name before re-sizing and applying to the regular sprite (and saving over the formerly @2x sized wrongly named .xcf file).
Perhaps I don't understand how these things are managed...
I thought that there was ONE source https://github.com/endless-sky/endless-sky-assets that drove two repositories
- normal resolution: https://github.com/endless-sky/endless-sky
- hi res @2x: https://github.com/endless-sky/endless-sky-high-dpi
The assets repo, from my understanding exists to make ALL assets of all sizes -- that or we have two sources and I don't know about the other one.
The .xcf file(s) exists to apply shadow to the output from the .svg, which I thought was the basis for both resolutions.
This PR (#186) is for the source material, which now has a .xcf file scaled for each resolution for the application of shading to the pristine .svg source to generate .png files which then go to the two repositories for resulting sprites.
Good question. xobes, the 2x should probably be in a PR to the high dpi plugin.
^-- your link is to the main repo, not the plugin.
endless-sky/endless-sky#10743
Artwork Checklist