-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optional max_file_size for parsing form files #2718
base: master
Are you sure you want to change the base?
Conversation
2d62595
to
bc3b9c3
Compare
bc3b9c3
to
d44aa98
Compare
If we instead make the |
But from what I see here is that this is only applied to non file parts. |
Hmmm... Does it make sense to be only on non file parts tho? 🤔 |
@Kludex I think we need different limits for parts vs files. As files are spooled, we could allow larger size but for parts we want to have a stricter limit as it is stored in memory. |
@Kludex what do you think about making all of limits configurable? https://github.com/encode/starlette/pull/2798/files |
Summary
Limiting the size of file being uploaded in case the storage is limited or some business logic can't handle certain size.
Checklist