Remove USE_ES6_IMPORT_META setting #23171
Open
+13
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
brendandahl
approved these changes
Dec 16, 2024
brendandahl
reviewed
Dec 16, 2024
| @@ -44,7 +44,7 @@ export function processMacros(text, filename) { | |||
| // Also handles #include x.js (similar to C #include <file>) | |||
| export function preprocess(filename) { | |||
| let text = read(filename); | |||
| if (EXPORT_ES6 && USE_ES6_IMPORT_META) { | |||
| if (EXPORT_ES6) { | |||
| // `eval`, Terser and Closure don't support module syntax; to allow it, | |||
There was a problem hiding this comment.
Potential follow up: I'm pretty sure closure supports module syntax now. Not sure about terser.
There was a problem hiding this comment.
I looked into this and will try to come up with followup. For now is seems like the eval phase is the one were we still need this.
sbc100
force-pushed
the
USE_ES6_IMPORT_META
branch
2 times, most recently
from
4e72877 to
2a546ac
Compare
This setting was added (IIUC) as a temporary workaround for the lack or support for `import.meta` in browser and tooling. However `import.meta` has been at stage 4 for almost 5 years now: tc39/proposal-import-meta#21 Webback (released in 2020) also has builtin support for `import.meta`, so I would hope the use case for disabling this setting no longer exists. See emscripten-core#9234 and emscripten-core#8729
sbc100
force-pushed
the
USE_ES6_IMPORT_META
branch
from
2a546ac to
79f3fef
Compare
VirtualTim
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting was added (IIUC) as a temporary workaround for the lack or support for
import.metain browser and tooling.However
import.metahas been at stage 4 for almost 5 years now: tc39/proposal-import-meta#21Webback (released in 2020) also has builtin support for
import.meta, so I would hope the use case for disabling this setting no longer exists.See #9234 and #8729