Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Gtk4 #90

Merged
merged 20 commits into from
Dec 15, 2024
Merged

Port to Gtk4 #90

merged 20 commits into from
Dec 15, 2024

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Sep 25, 2024 •
edited
Loading

Fix #80

  • Implement DnD
  • Refactor Gtk.Menu

danirabbit
danirabbit requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but it looks like maybe this isn't actually ready for review? There's a lot of commented code

src/Application.vala Outdated Show resolved Hide resolved
data/Application.css Outdated Show resolved Hide resolved
src/Frontend/Widgets/ConnectBox.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Show resolved Hide resolved
@alainm23
Copy link
Contributor Author

I still have some features pending, but thanks for the comments.

@alainm23 alainm23 requested a review from danirabbit September 26, 2024 01:03
@danirabbit
Copy link
Collaborator

Ah yeah it popped up in my notifications. Maybe better to set to draft until it's ready :)

@alainm23 alainm23 marked this pull request as draft September 26, 2024 10:57
@alainm23 alainm23 marked this pull request as ready for review September 30, 2024 10:29
ryonakano
ryonakano reviewed Oct 5, 2024
View reviewed changes
src/meson.build Show resolved Hide resolved
src/meson.build Outdated Show resolved Hide resolved
@alainm23 alainm23 requested a review from ryonakano October 8, 2024 01:23
@ryonakano
Copy link
Member

Sorry, could you revert changes against the translation files themselves? These changes often make the PR bigger so we should update the translation files later in another PR or commit

@alainm23 alainm23 requested a review from danirabbit October 14, 2024 17:23
ryonakano
ryonakano reviewed Oct 18, 2024
View reviewed changes
src/Backend/FileOperations.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/ConnectBox.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
alainm23 and others added 3 commits October 19, 2024 00:21
@alainm23 @ryonakano
Actualizar FileOperations.vala
e8051fa 
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@alainm23
fix operation popover
87874ee
@alainm23
fix lint
57c30f5
@alainm23 alainm23 requested a review from ryonakano October 28, 2024 20:27
ryonakano
ryonakano reviewed Oct 30, 2024
View reviewed changes
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
@alainm23 alainm23 requested a review from ryonakano November 14, 2024 13:57
@alainm23 alainm23 merged commit 4dcb5b2 into main Dec 15, 2024
3 checks passed
@alainm23 alainm23 deleted the feat/port-gtk4 branch December 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit Awaiting requested review from danirabbit

@ryonakano ryonakano Awaiting requested review from ryonakano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Gtk4
3 participants
@alainm23 @danirabbit @ryonakano