Avoid races between enabling the send queue and receiving back a stat…

…us update, stop dropping duplicates both here and on reachability status printing.
element-hq · Jun 21, 2024 · 341b6df · 341b6df
1 parent bdaa50c
commit 341b6df
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/ElementX/Sources/Application/AppCoordinator.swift b/ElementX/Sources/Application/AppCoordinator.swift
@@ -665,7 +665,6 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg
         let reachabilityNotificationIdentifier = "io.element.elementx.reachability.notification"
         ServiceLocator.shared.networkMonitor
             .reachabilityPublisher
-            .removeDuplicates()
             .sink { reachability in
                 MXLog.info("Reachability changed to \(reachability)")
 

diff --git a/ElementX/Sources/Services/Client/ClientProxy.swift b/ElementX/Sources/Services/Client/ClientProxy.swift
@@ -173,11 +173,10 @@ class ClientProxy: ClientProxyProtocol {
         })
 
         sendQueueStatusSubject
-            .removeDuplicates()
             .combineLatest(networkMonitor.reachabilityPublisher)
             .debounce(for: 1.0, scheduler: DispatchQueue.main)
             .sink { enabled, reachability in
-                MXLog.info("Send queue status changed to enabled: \(enabled)")
+                MXLog.info("Send queue status changed to enabled: \(enabled), reachability: \(reachability)")
 
                 if enabled == false, reachability == .reachable {
                     MXLog.info("Enabling all send queues")