fix(coroutine) : make sure to switch coroutine context #4146
Conversation
… not safe to use on main thread.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4146 +/- ##
========================================
Coverage 83.26% 83.26%
========================================
Files 1885 1885
Lines 49127 49127
Branches 5774 5774
========================================
Hits 40907 40907
Misses 6144 6144
Partials 2076 2076 ☔ View full report in Codecov by Sentry. |
| } | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
There is no change here, just to confirm.
There was a problem hiding this comment.
Nope, the method is not suspending
| override suspend fun canUserInvite(userId: UserId): Result<Boolean> { | ||
| return runCatching { | ||
| override suspend fun canUserInvite(userId: UserId): Result<Boolean> = withContext(roomDispatcher) { | ||
| runCatching { |
There was a problem hiding this comment.
Maybe introduce an extension like
suspend fun <T> CoroutineContext.invokeInner(block: suspend () -> T): Result<T> = withContext(this) {
runCatching {
block()
}
}(with a better name...)
There was a problem hiding this comment.
Maybe later, but I'm not convinced this is necessary...
Content
Make sure to switch coroutine context as rust sdk is not safe to use on main thread.
Motivation and context
Fix ANRs and make sure code is safe to use from main thread under any circumstance.
Replaces #4133
Tests
Tested devices
Checklist