Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(design) : use ElementTheme.typography.fontBodyLgMedium #4145

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jan 14, 2025

Content

What the title says

Motivation and context

To follow figma https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=1954-2511&m=dev

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added PR-Change For updates to an existing feature Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Jan 14, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Taz4Zs

@ganfra ganfra marked this pull request as ready for review January 14, 2025 10:46
@ganfra ganfra requested a review from a team as a code owner January 14, 2025 10:46
@ganfra ganfra requested review from bmarty and removed request for a team January 14, 2025 10:46
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (c7dbc7a) to head (20a4ea1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4145      +/-   ##
===========================================
- Coverage    83.26%   83.26%   -0.01%     
===========================================
  Files         1885     1885              
  Lines        49127    49121       -6     
  Branches      5774     5770       -4     
===========================================
- Hits         40907    40901       -6     
  Misses        6144     6144              
  Partials      2076     2076              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have checked on various Figma files and the typo fontBodyLgMedium seems to be used everywhere.

@ganfra ganfra merged commit f31e648 into develop Jan 14, 2025
28 checks passed
@ganfra ganfra deleted the feature/fga/design_button_text_style branch January 14, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants