Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kover #1782

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Upgrade kover #1782

merged 7 commits into from
Jan 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 9, 2023

Migrate to Kover 0.7.5

Report are now located in the :app module.

Verify and Html report tested OK locally.
First commits are just removing old empty modules.

@bmarty bmarty force-pushed the feature/bma/upgradeKover branch from ea5fc04 to 9ff3120 Compare January 8, 2024 13:31
@bmarty bmarty force-pushed the feature/bma/upgradeKover branch from 33fab91 to 80c69e7 Compare January 9, 2024 10:04
@element-hq element-hq deleted a comment from sonarqubecloud bot Jan 9, 2024
@element-hq element-hq deleted a comment from ElementBot Jan 9, 2024
@element-hq element-hq deleted a comment from github-actions bot Jan 9, 2024
@element-hq element-hq deleted a comment from sonarqubecloud bot Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/72HdFc

@ElementBot
Copy link
Collaborator

ElementBot commented Jan 9, 2024

Warnings
⚠️

gradle/libs.versions.toml#L94 - A newer version of androidx.compose.material3:material3 than 1.2.0-alpha11 is available: 1.2.0-beta01

Generated by 🚫 dangerJS against 45fd075

@bmarty bmarty marked this pull request as ready for review January 9, 2024 10:25
@bmarty bmarty requested a review from a team as a code owner January 9, 2024 10:25
@bmarty bmarty requested review from jmartinesp and removed request for a team January 9, 2024 10:25
@bmarty
Copy link
Member Author

bmarty commented Jan 9, 2024

OK, I have now the same error than when running locally:

Caused by: kotlinx.kover.gradle.plugin.commons.KoverVerificationException: Rule 'Global minimum code coverage.' violated: instructions covered percentage is 23.521500, but expected minimum is 65

Maybe we could just remove the excludeTests block (trying right now to see the impact).

@jmartinesp
Copy link
Member

jmartinesp commented Jan 9, 2024

OK, I have now the same error than when running locally:

Caused by: kotlinx.kover.gradle.plugin.commons.KoverVerificationException: Rule 'Global minimum code coverage.' violated: instructions covered percentage is 23.521500, but expected minimum is 65

Maybe we could just remove the excludeTests block (trying right now to see the impact).

I think it's not taking into account any screenshot test, it's the same issue we had before. All views have 0% of coverage.

app/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the new test run to finish and check that codecov is fine before merging.

bmarty and others added 2 commits January 9, 2024 17:07
It wasn't taking into account any test result from the debug runs or screenshot tests

Co-authored-by: Jorge Martin Espinosa <jorgem@element.io>
@bmarty bmarty force-pushed the feature/bma/upgradeKover branch from d10ed56 to 45fd075 Compare January 9, 2024 16:16
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bmarty bmarty merged commit 2bdf2c0 into develop Jan 9, 2024
13 checks passed
@bmarty bmarty deleted the feature/bma/upgradeKover branch January 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants