-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovery key with spaces #1759
Recovery key with spaces #1759
Conversation
…es, to let user enter passphrase
…oard type to password.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM and it works ok
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1759 +/- ##
========================================
Coverage 63.35% 63.36%
========================================
Files 1287 1288 +1
Lines 33366 33379 +13
Branches 6948 6952 +4
========================================
+ Hits 21139 21149 +10
- Misses 9049 9051 +2
- Partials 3178 3179 +1
☔ View full report in Codecov by Sentry. |
Type of change
Content
Disable recovery key formatting if a space is detected to let user enter passphrase without messing up the formatting.
Also change the field to behave like a password, to be able to provide the password from a password manager.
Motivation and context
Closes #1755
Screenshots / GIFs
Tests
Tested devices
Checklist