Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery key with spaces #1759

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Recovery key with spaces #1759

merged 4 commits into from
Nov 8, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 7, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Disable recovery key formatting if a space is detected to let user enter passphrase without messing up the formatting.
Also change the field to behave like a password, to be able to provide the password from a password manager.

Motivation and context

Closes #1755

Screenshots / GIFs

Tests

  • Go to the screen to enter a recovery key
  • Paste a recovery key in the field: the recovery key is entered and formatted to chunk of 4 chars.
  • Or type a passphrase. As soon of a space is entered, the formatting of recovery key is disabled.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner November 7, 2023 16:48
@bmarty bmarty requested review from jmartinesp and removed request for a team November 7, 2023 16:48
@bmarty bmarty mentioned this pull request Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uNZdJG

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM and it works ok

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (26c28ff) 63.35% compared to head (78d15c1) 63.36%.
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1759   +/-   ##
========================================
  Coverage    63.35%   63.36%           
========================================
  Files         1287     1288    +1     
  Lines        33366    33379   +13     
  Branches      6948     6952    +4     
========================================
+ Hits         21139    21149   +10     
- Misses        9049     9051    +2     
- Partials      3178     3179    +1     
Files Coverage Δ
...atures/securebackup/impl/tools/RecoveryKeyTools.kt 100.00% <100.00%> (ø)
...s/securebackup/impl/setup/views/RecoveryKeyView.kt 78.19% <88.88%> (+0.24%) ⬆️
...mpl/enter/SecureBackupEnterRecoveryKeyPresenter.kt 83.33% <60.00%> (-5.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 334f4f7 into develop Nov 8, 2023
14 checks passed
@bmarty bmarty deleted the feature/bma/recoveryKeyWithSpaces branch November 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyBackup: allow spaces
2 participants