Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Konsist tests always run #1590

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Make sure Konsist tests always run #1590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b404c2
Make sure Konsist tests always run
jmartinesp Oct 17, 2023
5858b43
Update tests/konsist/build.gradle.kts
jmartinesp Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/konsist/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,10 @@ dependencies {
testImplementation(projects.libraries.architecture)
testImplementation(projects.libraries.designsystem)
}

// Make sure Konsist tests are always run. This is needed because otherwise we'd have to either:
// - Add every single module as a dependency of this one.
// - Move the Konsist tests to a the app module, which was causing issues.
jmartinesp marked this conversation as resolved.
Show resolved Hide resolved
tasks.withType<Test>().configureEach {
outputs.upToDateWhen { false }
}
Copy link
Member

@bmarty bmarty Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konsist test are not always run because the konsist module does not depend on any other modules, except projects.libraries.architecture and projects.libraries.designsystem (see the lines above) because we need access to some external types.
Maybe add this in the comment above to explain why this patch is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in fb0bf38.

Loading