-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make themed widgets reflect the effective theme #28342
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.
b55cfb2
to
78e5230
Compare
78e5230
to
a05835f
Compare
Apologies for the force pushes. This is ready for another review but blocked on a related matrix-widget-api change. |
a05835f
to
4d91e97
Compare
So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
4d91e97
to
146db61
Compare
@robintown have these concerns been addressed? |
Yes, they have. I'm now updating the theme dynamically with a widget action. |
So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
Closes #27671
Depends on matrix-org/matrix-widget-api#117