Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the flaky add/remove 3pid test to playwright #28226

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Port the flaky add/remove 3pid test to playwright #28226

merged 1 commit into from
Oct 17, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 17, 2024

Fixes #28160

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr dbkr added the T-Task Tasks for the team like planning label Oct 17, 2024
@dbkr dbkr marked this pull request as ready for review October 17, 2024 15:03
@dbkr dbkr requested a review from a team as a code owner October 17, 2024 15:03
@dbkr dbkr requested review from t3chguy and robintown October 17, 2024 15:03
@dbkr dbkr added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit cb383ef Oct 17, 2024
43 checks passed
@dbkr dbkr deleted the dbkr/port_threepid_test_to_playwright branch October 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Jest test: AddRemoveThreepids › should display an error if the code is incorrect
2 participants
@dbkr @t3chguy