feat: Add refreshArrayTypes() call to re-sync newly created complex array columns, like enums
#500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwillis
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Hey @fgodino-milu this is awesome!!
It's almost perfect, I think the only thing we need to add Is the refreshArrayTypes to the PGliteInterface interface as thats what defines the universal interface we would want to expose from any pglite implementation (we have the main PGlite and PGliteWorker at the moment, but are likely to have others in future)
If you are happy to add that we can get this merged 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
Introduces a new method
refreshArrayTypesthat allows to resync the internal array types to handle the serialization and parsing.