Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PowerShell variant to MSI install docs #1548

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Add PowerShell variant to MSI install docs #1548

merged 4 commits into from
Dec 16, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Dec 16, 2024 •
edited
Loading

This updates the MSI install page since the PowerShell version of the install command for Elastic Agent is a bit different.

Closes: #1547

Screenshot 2024-12-16 at 2 02 29 PM

@kilfoyle kilfoyle requested a review from a team as a code owner December 16, 2024 18:29
@kilfoyle kilfoyle requested a review from strawgate December 16, 2024 18:29
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

This pull request does not have a backport label. Could you fix it @kilfoyle? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

shainaraskas
shainaraskas reviewed Dec 16, 2024
View reviewed changes
docs/en/ingest-management/elastic-agent/install-agent-msi.asciidoc
----
./elastic-agent-<VERSION>-windows-x86_64.msi --% INSTALLARGS="--url=<URL> --enrollment-token=<TOKEN>"
----
+
Where:
Copy link
Contributor

@shainaraskas shainaraskas Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the picky person in me is worried this looks like it applies to just the powershell command prompt. consider pulling out the bullets and making them all child paragraphs.

Copy link
Contributor Author

@kilfoyle kilfoyle Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shainaraskas I've changed it to this, so the hierarchy is right. I'd like to avoid child paragraphs since it would differ from the formatting other, similar docs.

Here's how it looks now:

Screenshot 2024-12-16 at 3 58 55 PM

shainaraskas
shainaraskas previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁 with a picky note

karenzone
karenzone approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kilfoyle kilfoyle merged commit 1d7deb2 into elastic:main Dec 16, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
@kilfoyle @mergify
Add PowerShell variant to MSI install docs (#1548)
71b3104 
* Add PowerShell variant to MSI install docs

* Change 'Bash' to 'default command prompt'

* change nesting of the variant command bullets

* re-add URL description

(cherry picked from commit 1d7deb2)
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
@kilfoyle @mergify
Add PowerShell variant to MSI install docs (#1548)
ca41d03 
* Add PowerShell variant to MSI install docs

* Change 'Bash' to 'default command prompt'

* change nesting of the variant command bullets

* re-add URL description

(cherry picked from commit 1d7deb2)
This was referenced Dec 16, 2024
Merged
Merged
kilfoyle added a commit that referenced this pull request Dec 16, 2024
@mergify @kilfoyle
Add PowerShell variant to MSI install docs (#1548) (#1565)
fa28ca3 
* Add PowerShell variant to MSI install docs

* Change 'Bash' to 'default command prompt'

* change nesting of the variant command bullets

* re-add URL description

(cherry picked from commit 1d7deb2)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Dec 16, 2024
@mergify @kilfoyle
Add PowerShell variant to MSI install docs (#1548) (#1564)
4ed1bf3 
* Add PowerShell variant to MSI install docs

* Change 'Bash' to 'default command prompt'

* change nesting of the variant command bullets

* re-add URL description

(cherry picked from commit 1d7deb2)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

@strawgate strawgate Awaiting requested review from strawgate

@shainaraskas shainaraskas Awaiting requested review from shainaraskas

Assignees
No one assigned
Labels
backport-8.x backport-8.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update MSI install docs for Powershell
3 participants
@kilfoyle @karenzone @shainaraskas