feat: limited ProcFDUsage support on darwin #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
❕ Build Aborted
Expand to view the summary
Build stats
|
|
I'll look into getting the CLA signed. I'll need to check with my employer so it might take a little bit of time. |
This adds support for ProcFDUsage on darwin when the requested PID matches that of the current process. On MacOS, while you can get the open file descriptors for other processes (via `proc_pidinfo`), I don't know of a clean way to get the current rlimit data for another process. However, for the current process, we can retrieve the rlimits via the `getrlimit` system call. I've used /dev/fd to count open files rather than `proc_pidinfo` because I think the code is a bit more straight forward than the under-documented `proc_pidinfo` call.
stevendanna
force-pushed
the
darwin-proc-fd-usage
branch
from
8eb96e0 to
1fcb209
Compare
|
Apologies on the delay getting the CLA signed. Should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for ProcFDUsage on darwin when the requested PID
matches that of the current process.
On MacOS, while you can get the open file descriptors for other
processes (via
proc_pidinfo), I don't know of a clean way to get thecurrent rlimit data for another process.
However, for the current process, we can retrieve the rlimits via the
getrlimitsystem call.I've used /dev/fd to count open files rather than
proc_pidinfobecause I think the code is a bit more straight forward than the
under-documented
proc_pidinfocall.It's totally understandable if you would prefer to avoid this kind
of conditional behavior.